kbuild: switch from lz4c to lz4 for compression
authorParth Pancholi <parth.pancholi@toradex.com>
Thu, 14 Nov 2024 14:56:44 +0000 (15:56 +0100)
committerSalvatore Bonaccorso <carnil@debian.org>
Sun, 2 Feb 2025 13:17:45 +0000 (14:17 +0100)
commitc268100824e39aea5d16a08c8388f9551261dc25
tree060529e8a81b817fa6f211dbc74c25784fcc45d2
parent97a1076d560cd5971e84261fcb9a3a03b7d66bb9
kbuild: switch from lz4c to lz4 for compression

Origin: https://git.kernel.org/linus/e397a603e49cc7c7c113fad9f55a09637f290c34

Replace lz4c with lz4 for kernel image compression.
Although lz4 and lz4c are functionally similar, lz4c has been deprecated
upstream since 2018. Since as early as Ubuntu 16.04 and Fedora 25, lz4
and lz4c have been packaged together, making it safe to update the
requirement from lz4c to lz4.

Consequently, some distributions and build systems, such as OpenEmbedded,
have fully transitioned to using lz4. OpenEmbedded core adopted this
change in commit fe167e082cbd ("bitbake.conf: require lz4 instead of
lz4c"), causing compatibility issues when building the mainline kernel
in the latest OpenEmbedded environment, as seen in the errors below.

This change also updates the LZ4 compression commands to make it backward
compatible by replacing stdin and stdout with the '-' option, due to some
unclear reason, the stdout keyword does not work for lz4 and '-' works for
both. In addition, this modifies the legacy '-c1' with '-9' which is also
compatible with both. This fixes the mainline kernel build failures with
the latest master OpenEmbedded builds associated with the mentioned
compatibility issues.

LZ4     arch/arm/boot/compressed/piggy_data
/bin/sh: 1: lz4c: not found
...
...
ERROR: oe_runmake failed

Link: https://github.com/lz4/lz4/pull/553
Suggested-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name kbuild-switch-from-lz4c-to-lz4-for-compression.patch
Makefile
scripts/Makefile.lib